Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default kubernetes version to 1.18.2 #6064

Merged
merged 1 commit into from
May 6, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented May 1, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update default kubernetes version to 1.18.2

Which issue(s) this PR fixes:
Fixes #5859

Special notes for your reviewer:
Let's see what CI is thinking and not wait as long as we did with 2.13 :)

Does this PR introduce a user-facing change?:

Update default kubernetes version to 1.18.2

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels May 1, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten May 1, 2020 17:13
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 1, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2020
@floryut floryut marked this pull request as ready for review May 2, 2020 07:41
@floryut floryut changed the title WIP - Use k8s 1.18 as default WIP - Update default kubernetes version to 1.18.2 May 2, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2020
@floryut floryut changed the title WIP - Update default kubernetes version to 1.18.2 Update default kubernetes version to 1.18.2 May 2, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented May 2, 2020

Any kubeadm changes to consider as well?

@floryut
Copy link
Member Author

floryut commented May 2, 2020

Any kubeadm changes to consider as well?

Well I guess we have at least some kind of deprecated thing

TASK [kubernetes/node : sets kubeadm api version to v1beta1] *******************
�[1;30mtask path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/node/tasks/kubelet.yml:13�[0m
�[1;30m�[0mSaturday 02 May 2020 08:55:58 +0000 (0:00:01.215) 0:13:28.839 **********
�[0;32mok: [instance-2] => {"ansible_facts": {"kubeadmConfig_api_version": "v1beta1"}, "changed": false}�[0m
�[0;32m�[0m�[0;32mok: [instance-1] => {"ansible_facts": {"kubeadmConfig_api_version": "v1beta1"}, "changed": false}�[0m
�[0;32m�[0m

with those warning

your configuration file uses a deprecated API spec: "kubeadm.k8s.io/v1beta1". Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml

@Miouge1
Copy link
Contributor

Miouge1 commented May 3, 2020

I started all optional CI jobs to see if anything pops up there as well (except ubuntu 20.04 which is supposed to fail anyway).

@Miouge1
Copy link
Contributor

Miouge1 commented May 3, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2020
@EppO
Copy link
Contributor

EppO commented May 5, 2020

Any kubeadm changes to consider as well?

Well I guess we have at least some kind of deprecated thing

TASK [kubernetes/node : sets kubeadm api version to v1beta1] *******************
�[1;30mtask path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/node/tasks/kubelet.yml:13�[0m
�[1;30m�[0mSaturday 02 May 2020 08:55:58 +0000 (0:00:01.215) 0:13:28.839 **********
�[0;32mok: [instance-2] => {"ansible_facts": {"kubeadmConfig_api_version": "v1beta1"}, "changed": false}�[0m
�[0;32m�[0m�[0;32mok: [instance-1] => {"ansible_facts": {"kubeadmConfig_api_version": "v1beta1"}, "changed": false}�[0m
�[0;32m�[0m

with those warning

your configuration file uses a deprecated API spec: "kubeadm.k8s.io/v1beta1". Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml

ok so we need to support both versions moving forward, to get rid of that warning.

@EppO
Copy link
Contributor

EppO commented May 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit c06f482 into kubernetes-sigs:master May 6, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release for k8s 1.18
4 participants