Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Vagrant CI use unsafe I/O #6058

Merged
merged 1 commit into from
May 1, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented May 1, 2020

What this PR does / why we need it:
If the server reboots, the CI job will fail anyway, so we are not concerned with writes being persisted on disk.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO May 1, 2020 11:40
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 1, 2020
@Miouge1
Copy link
Contributor Author

Miouge1 commented May 1, 2020

/retest

@floryut
Copy link
Member

floryut commented May 1, 2020

Trusting you on that 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 01dbc90 into kubernetes-sigs:master May 1, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request May 2, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants