Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimal ansible version to 2.8.0 #5984

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Apr 18, 2020

/kind bug

What this PR does / why we need it:

ansible 2.7.x fail with error

 {"msg": "The conditional check '{{ 'bootstrap-os' not in ansible_play
_role_names }}' failed. The error was: error while evaluating conditional ({{ 'bootstrap-os' not in ansible_play_role_names }}): Unable to look up a name or a
ccess an attribute in template string ({{ 'bootstrap-os' not in ansible_play_role_names }}).\nMake sure your variable name does not contain invalid characters
 like '-': argument of type 'StrictUndefined' is not iterable\n\nThe error appears to have been in '/srv/kubespray/roles/kubespray-defaults/tasks/main.yaml':
line 9, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# do not run gather facts w
hen bootstrap-os in roles\n- name: set fallback_ips\n  ^ here\n"}

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten April 18, 2020 21:53
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 19, 2020

Since requirements.txt is Ansible 2.9 we might want to use that for minimum version?

Might be nice to have a variable similar to keep the minimum version only in 1 place?

@LuckySB
Copy link
Contributor Author

LuckySB commented Apr 19, 2020

Since requirements.txt is Ansible 2.9 we might want to use that for minimum version?

Might be nice to have a variable similar to keep the minimum version only in 1 place?

I think that it is necessary to diff between the minimum and recommended version.
I upgraded the version of ansible to 2.8, because 2.7 fail with an error.
Many people install ansible not through pip

@Miouge1 Miouge1 added this to the 2.13 milestone Apr 21, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 22, 2020

Thank you @LuckySB

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit aead0e3 into kubernetes-sigs:master Apr 22, 2020
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Apr 24, 2020
* bump minimal ansible version to 2.8.0

* check ansible version in separate playbook
spaced pushed a commit to spaced/kubespray that referenced this pull request Jun 10, 2024
New Features:

NGINX 1.19.2
New configmap option enable-real-ip to enable realip_module
Use k8s.gcr.io vanity domain
Go 1.15
client-go v0.18.6
Migrate to klog v2
Changes:

 kubernetes-sigs#5887 Add force-enable-realip-module
 kubernetes-sigs#5888 Update dev-env.sh script
 kubernetes-sigs#5923 Fix error in grpcbin deployment and enable e2e test
 kubernetes-sigs#5924 Validate endpoints are ready in e2e tests
 kubernetes-sigs#5931 Add opentracing operation name settings
 kubernetes-sigs#5933 Update opentracing nginx module
 kubernetes-sigs#5946 Do not add namespace to cluster-scoped resources
 kubernetes-sigs#5951 Use env expansion to provide namespace in container args
 kubernetes-sigs#5952 Refactor shutdown e2e tests
 kubernetes-sigs#5957 bump fsnotify to v1.4.9
 kubernetes-sigs#5958 Disable enable-access-log-for-default-backend e2e test
 kubernetes-sigs#5984 Fix panic in ingress class validation
 kubernetes-sigs#5986 Migrate to klog v2
 kubernetes-sigs#5987 Fix wait times in e2e tests
 kubernetes-sigs#5990 Fix nginx command env variable reference
 kubernetes-sigs#6004 Update nginx to 1.19.2
 kubernetes-sigs#6006 Update nginx image
 kubernetes-sigs#6007 Update e2e-test-runner image
 kubernetes-sigs#6008 Rollback update of Jaeger library to 0.5.0 and update datadog to 1.2.0
 kubernetes-sigs#6014 Update go dependencies
 kubernetes-sigs#6039 Add configurable serviceMonitor metricRelabelling and targetLabels
 kubernetes-sigs#6046 Add new Dockerfile label org.opencontainers.image.revision
 kubernetes-sigs#6047 Increase wait times in e2e tests
 kubernetes-sigs#6049 Improve docs and logging for --ingress-class usage
 kubernetes-sigs#6052 Fix flaky e2e test
 kubernetes-sigs#6056 Rollback to Poll instead of PollImmediate
 kubernetes-sigs#6062 Adjust e2e timeouts
 kubernetes-sigs#6063 Remove file system paths executables
 kubernetes-sigs#6080 Use k8s.gcr.io vanity domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants