-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Calico to v3.13.2, Multus to v3.4.1. #5894
Conversation
Hi @alexkross. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexkross The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexkross Didn't you forget to add |
Yes. I do. Updated. Thanks. |
…ck (kubernetes-sigs#5847) * requirements.txt: Bump versions Ansible 2.8+ allow ansible_python_interpreter autodetection Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * tests: do not force ansible_python_interpreter we do not expect people to set ansible_python_interpreter, so we should not set it in the CI Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
* requirements.txt: Bump versions Ansible 2.8+ allow ansible_python_interpreter autodetection Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * tests: do not force ansible_python_interpreter we do not expect people to set ansible_python_interpreter, so we should not set it in the CI Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * Add CentOS 8 Calico to CI Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
…kubernetes-sigs#5896) * Fix chicken and egg problem with proxy_env not defined on the first envinronment usage. * Disable fact gathering for the first proxy_env evaluation. * Move proxy_env var set up from the role defaults to the root playbooks as fact.
CI is showing CrashLoopBackOff in packet_centos7-calico-ha-once-localhost
This PR might require #5895 ? |
* etcd: etcd-events doesn't depend on etcd_cluster_setup Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * etcd: remove condition already present on include_tasks Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * etcd: fix scaling up Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * etcd: use *access_addresses, do not delegate to etcd[0] We want to wait for the full cluster to be healthy, so use all the cluster addresses Also we should be able to run the playbook when etcd[0] is down (not tested), so do not delegate to etcd[0] Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * etcd: use failed_when for health check unhealthy cluster is expected on first run, so use failed_when instead of ignore_errors to remove scary red messages Also use run_once Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * kubernetes/preinstall: ensure ansible_fqdn is up to date after changing /etc/hosts Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com> * kubernetes/master: regenerate apiserver cert if needed Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
I think you are right. |
@alexkross can you do a single PR for the changes in #5894 and #5895 ? Maybe keep this one and close the other one. |
…spray into upd-calico-multus
If you can and have some time to do so, that'd be great, cleaner and easier :) |
/close In favor of #5912 |
@alexkross: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE