Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calico to v3.13.2, Multus to v3.4.1. #5894

Closed
wants to merge 22 commits into from

Conversation

alexkross
Copy link
Contributor

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Update.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alexkross. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexkross
To complete the pull request process, please assign chadswen
You can assign the PR to them by writing /assign @chadswen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten April 5, 2020 21:08
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2020
@floryut
Copy link
Member

floryut commented Apr 6, 2020

@alexkross Didn't you forget to add calicoctl hashes for arm64 and arm (even if set to 0) ?

@alexkross
Copy link
Contributor Author

@alexkross Didn't you forget to add calicoctl hashes for arm64 and arm (even if set to 0) ?

Yes. I do. Updated. Thanks.

champtar and others added 8 commits April 7, 2020 01:47
…ck (kubernetes-sigs#5847)

* requirements.txt: Bump versions

Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* tests: do not force ansible_python_interpreter

we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
* requirements.txt: Bump versions

Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* tests: do not force ansible_python_interpreter

we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* Add CentOS 8 Calico to CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
…kubernetes-sigs#5896)

* Fix chicken and egg problem with proxy_env not defined on the first envinronment usage.

* Disable fact gathering for the first proxy_env evaluation.

* Move proxy_env var set up from the role defaults to the root playbooks as fact.
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 8, 2020

CI is showing CrashLoopBackOff in packet_centos7-calico-ha-once-localhost kubectl logs shows:

2020-04-08 08:24:37.677 [ERROR][8] startup.go 182: failed to query kubeadm's config map error=configmaps "kubeadm-config" is forbidden: User "system:serviceaccount:kube-system:calico-node" cannot get resource "configmaps" in API group "" in the namespace "kube-system"

This PR might require #5895 ?

champtar and others added 3 commits April 8, 2020 01:27
* etcd: etcd-events doesn't depend on etcd_cluster_setup

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* etcd: remove condition already present on include_tasks

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* etcd: fix scaling up

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* etcd: use *access_addresses, do not delegate to etcd[0]

We want to wait for the full cluster to be healthy,
so use all the cluster addresses
Also we should be able to run the playbook when etcd[0] is down
(not tested), so do not delegate to etcd[0]

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* etcd: use failed_when for health check

unhealthy cluster is expected on first run, so use failed_when
instead of ignore_errors to remove scary red messages

Also use run_once

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* kubernetes/preinstall: ensure ansible_fqdn is up to date after changing /etc/hosts

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* kubernetes/master: regenerate apiserver cert if needed

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@alexkross
Copy link
Contributor Author

CI is showing CrashLoopBackOff in packet_centos7-calico-ha-once-localhost kubectl logs shows:

2020-04-08 08:24:37.677 [ERROR][8] startup.go 182: failed to query kubeadm's config map error=configmaps "kubeadm-config" is forbidden: User "system:serviceaccount:kube-system:calico-node" cannot get resource "configmaps" in API group "" in the namespace "kube-system"

This PR might require #5895 ?

I think you are right.
It would be better to rebase onto #5895 .

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 8, 2020

@alexkross can you do a single PR for the changes in #5894 and #5895 ?

Maybe keep this one and close the other one.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2020
@alexkross
Copy link
Contributor Author

alexkross commented Apr 8, 2020

@Miouge1 before merge calico-cr-missing-cm-perm ( #5895 ) i did rebase to the latest master and now see that history looks bloated.
Maybe I still need to follow your original variant suggestion to make another clean single PR for the changes in #5894 and #5895 based on current master branch?

@floryut
Copy link
Member

floryut commented Apr 8, 2020

@Miouge1 before merge calico-cr-missing-cm-perm ( #5895 ) i did rebase master and now see that history looks bloated.
Maybe I still need to follow your original variant suggestion to make another clean single PR for the changes in #5894 and #5895 based on current master branch?

If you can and have some time to do so, that'd be great, cleaner and easier :)

@alexkross
Copy link
Contributor Author

alexkross commented Apr 8, 2020

/close

In favor of #5912

@k8s-ci-robot
Copy link
Contributor

@alexkross: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexkross alexkross deleted the upd-calico-multus branch April 9, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.