-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables to configure Containerd default runtime, untrusted runt… #5497
Add variables to configure Containerd default runtime, untrusted runt… #5497
Conversation
/assign @Miouge1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasqualet thank you for your contribution, could you add the new vars in the sample inventory as well?
…ime and additional runtimes
75b3348
to
cd41d52
Compare
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3087e42
to
4c6afc1
Compare
@Miouge1 I've updated the sample inventory |
Great! Looks good to me. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, pasqualet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-sigs#5497) * Add variables to configure Containerd default runtime, untrusted runtime and additional runtimes * Add containerd settings to sample inventory * Empty commit
…ime and additional runtimes
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables the configuration of containerd runtimes: default runtime, untrusted runtime and additional runtimes.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: