Fixes an issue with offline installations #5394
Conversation
… return an empty dict which passed as a valid fallback_ip dict item
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @eddebc! |
k8s-ci-robot
added
the
size/XS
|
I signed the CLA. Emailed support. |
|
/check-cla |
k8s-ci-robot
added
cncf-cla: yes
|
/assign @riverzhang |
| fallback_ips_base: | | ||
| --- | ||
| {% for item in groups['k8s-cluster'] + groups['etcd'] + groups['calico-rr']|default([])|unique %} | ||
| {{ item }}: "{{ hostvars[item].get('ansible_default_ipv4', {'address': '127.0.0.1'})['address'] }}" | ||
| {% set found = hostvars[item].get('ansible_default_ipv4') %} |
There was a problem hiding this comment.
you could just use ['ansible_default_ipv4'] here no ?
|
Can someone review and merge this ? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddebc, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
… return an empty dict which passed as a valid fallback_ip dict item (kubernetes-sigs#5394)
What type of PR is this?
/kind bug
What this PR does / why we need it:
Better support for offline installations.
Which issue(s) this PR fixes:
Fixes #5374 #5217
Special notes for your reviewer:
When 'ansible_default_ipv4' returns an empty dict, it "tells"
hostvars[item].getthat the key exists. This causes the empty dict to be used rather than{'address': '127.0.0.1'}. An empty dict is returned because there is no default gateway, which some offline installations don't have. This helped me.Does this PR introduce a user-facing change?: