Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation in cilium-ds.yml template #5305

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix indentation in cilium-ds.yml template #5305

merged 1 commit into from
Nov 11, 2019

Conversation

sandhose
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
There was an indentation issue in the Cilium DaemonSet template, which made the file invalid when trying to setup a cluster with containerd as container engine.

Which issue(s) this PR fixes:

Fixes #5175

Special notes for your reviewer:
–

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Welcome @sandhose!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2019
@mattymo
Copy link
Contributor

mattymo commented Nov 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, sandhose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8a406be into kubernetes-sigs:master Nov 11, 2019
erulabs added a commit to kubesail/kubespray that referenced this pull request Nov 18, 2019
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
5d1c88d 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (28 commits)
  Do not run kubeadm upgrade on first deploy (kubernetes-sigs#5339)
  Added Amazon Linux 2 support for deploying with docker (kubernetes-sigs#5301)
  Set certs and files with kubeadm token to mode 0640 (kubernetes-sigs#5325)
  Fix calico name resolution (kubernetes-sigs#5291)
  library files added to setup.cfg (kubernetes-sigs#5274)
  Fix helm for Kubernetes 1.16.2 (kubernetes-sigs#5332)
  Pass `ingress_nginx_extra_args` when deploying the nginx-ingress addon (kubernetes-sigs#5321)
  Respect cri-tool supported version matrix (kubernetes-sigs#5241)
  fix useradd etcd (kubernetes-sigs#5281)
  Fix indentation in cilium-ds.yml template (kubernetes-sigs#5305)
  Remove default docker_options from sample (kubernetes-sigs#5287)
  Add cilium_tunnel_mode variable to the cilium config (kubernetes-sigs#5295)
  Fixes issue kubernetes-sigs#5299 (kubernetes-sigs#5300)
  containerd installation on Debian (kubernetes-sigs#5326)
  Skip coredns image when evaluating kubeadm images (kubernetes-sigs#5327)
  [FIX] fix incorrect link to downloads documentation (kubernetes-sigs#5319)
  Remove unnecessary and risky reload network for resolvconf propagation (kubernetes-sigs#5322)
  Enable systemd-resolved DNS resolution mode (kubernetes-sigs#5318)
  Scale down coredns created by kubeadm upgrade to 0 replicas (kubernetes-sigs#5308)
  Deploy Cinder CSI driver to provision volumes over OpenStack (kubernetes-sigs#5184)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Dec 9, 2019
@sandhose @LuckySB
Fix indentation in cilium-ds.yml template (kubernetes-sigs#5305)
2bdcf13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@Miouge1 Miouge1 Awaiting requested review from Miouge1

Assignees

@mattymo mattymo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indentation error in cilium-ds.yml results in error when deploying the cluster with Cilium and CRI-O
3 participants
@sandhose @k8s-ci-robot @mattymo