containerd: always use config_path #11755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
VannTen
changed the title
config_path was introduced in containerd 1.5.0, and registry.mirrors is deprecated. There is no reason to keep the old alternative, so just always use config_path, and consequently remove the option.
VannTen
force-pushed
the
cleanup/container_config_path
branch
from
b0611f9 to
a342a64
Compare
|
Thanks @VannTen ! lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kpoxo6op
pushed a commit
to kpoxo6op/kubespray
that referenced
this pull request
Dec 27, 2024
config_path was introduced in containerd 1.5.0, and registry.mirrors is deprecated. There is no reason to keep the old alternative, so just always use config_path, and consequently remove the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
config_path was introduced in containerd 1.5.0, and registry.mirrors is
deprecated.
There is no reason to keep the old alternative, so just always use
config_path, and consequently remove the option.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Ideally we would have first defaulted to config_path before removing the option, but I don't think there is a downside.
It's up for discussion though if I missed some shortcomings (in that case I will only default to true)
Does this PR introduce a user-facing change?: