-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix task naming in bootstrap-os #11714
fix task naming in bootstrap-os #11714
Conversation
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Does this apply in those other places:
too? |
@MrFreezeex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah indeed makes sense, I am guessing that we don't have this fact yet in the bootstrap phase and thus we need to get it via another way which is unfortunately not consistent with other places :/
/lgtm
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-2.25 |
@VannTen: new pull request created: #11718 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@VannTen: new pull request created: #11719 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The naming of some task files in bootstrap-os doesn't match the ID values in the actual os-release file, which will cause the related OS tasks not to be executed.
Which issue(s) this PR fixes:
Fixes #11712
Special notes for your reviewer:
Does this PR introduce a user-facing change?: