Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for openEuler 24.03 #11689

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add CI for openEuler 24.03 #11689

merged 1 commit into from
Nov 12, 2024

Conversation

yankay
Copy link
Member

@yankay yankay commented Nov 5, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add CI Image for openEuler 24.03

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add CI for openeuler 24.03
Add CI Image for openeuler 24.03, 22.03

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2024
@yankay
Copy link
Member Author

yankay commented Nov 5, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 5, 2024
@yankay
Copy link
Member Author

yankay commented Nov 5, 2024

/ok-to-test

@yankay yankay changed the title [WIP]Add CI Image for openeuler 22.03 [WIP]Add CI for openeuler 22.03 Nov 5, 2024
@yankay yankay force-pushed the add-ci-for-openeuler branch from 377ef2e to 3f64baa Compare November 5, 2024 10:22
@yankay yankay changed the title [WIP]Add CI for openeuler 22.03 [WIP]Add CI for openEuler 22.03 Nov 5, 2024
@yankay yankay force-pushed the add-ci-for-openeuler branch from 3f64baa to c110c6e Compare November 5, 2024 11:09
@yankay yankay closed this Nov 5, 2024
@yankay yankay reopened this Nov 5, 2024
@yankay yankay closed this Nov 6, 2024
@yankay yankay reopened this Nov 6, 2024
@yankay
Copy link
Member Author

yankay commented Nov 6, 2024

/retest

@yankay yankay force-pushed the add-ci-for-openeuler branch 2 times, most recently from f99644d to a2a2e79 Compare November 6, 2024 01:33
@yankay yankay changed the title [WIP]Add CI for openEuler 22.03 Add CI for openEuler 22.03 Nov 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@yankay yankay changed the title Add CI for openEuler 22.03 [WIP]Add CI for openEuler 22.03 Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@yankay yankay force-pushed the add-ci-for-openeuler branch 4 times, most recently from 4c8139f to b41050f Compare November 6, 2024 03:19
@yankay yankay force-pushed the add-ci-for-openeuler branch 3 times, most recently from e789a3d to 2ab51b7 Compare November 6, 2024 07:23
@yankay yankay changed the title [WIP]Add CI for openEuler 22.03 Add CI for openEuler 22.03 Nov 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@yankay yankay changed the title Add CI for openEuler 22.03 Add CI for openEuler 24.03 Nov 6, 2024
@yankay yankay force-pushed the add-ci-for-openeuler branch from 2ab51b7 to c9b9951 Compare November 6, 2024 07:26
@yankay
Copy link
Member Author

yankay commented Nov 7, 2024

HI @VannTen @ErikJiang @cyclinder

Would you please help to review it

tico88612
tico88612 reviewed Nov 7, 2024
View reviewed changes
test-infra/image-builder/roles/kubevirt-images/defaults/main.yml
Comment on lines +128 to +133
openeuler-2203:
filename: openEuler-22.03-LTS-SP4-x86_64.qcow2.xz
url: https://mirrors.ocf.berkeley.edu/openeuler/openEuler-22.03-LTS-SP4/virtual_machine_img/x86_64/openEuler-22.03-LTS-SP4-x86_64.qcow2.xz
checksum: sha256:2dc9c9d73d172af0443d1a17786ee2e387006b9912fad24b5497ef103ecd7afb
converted: true
tag: "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test for OpenEuler-2203?
I don't seem to see anything about OpenEuler-2203 testing?

Copy link
Member Author

@yankay yankay Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is currently no CI (may not be needed), but the image has been pushed at: https://quay.io/repository/kubespray/vm-openeuler-2203
It may useful when we need to add it later.

@VannTen
Copy link
Contributor

VannTen commented Nov 10, 2024

"msg": "Failed to create object: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"admission webhook \\"virtualmachine-validator.kubevirt.io\\" denied the request: spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64.cloudInitNoCloud.userDataBase64 is not a valid base64 value.","reason":"Invalid","details":{"causes":[{"reason":"FieldValueInvalid","message":"spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64.cloudInitNoCloud.userDataBase64 is not a valid base64 value.","field":"spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64"}]},"code":422}\n'", "reason": "Unprocessable Entity

Failure (of the openeuler job) looks relevant
Also, why put it in extended rather than regular runs ? Not stable enough ?

@yankay yankay force-pushed the add-ci-for-openeuler branch from c9b9951 to 43c8f91 Compare November 11, 2024 02:38
@yankay
add ci for openeuler
6ea7a6a 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the add-ci-for-openeuler branch from 43c8f91 to 6ea7a6a Compare November 11, 2024 02:39
@yankay
Copy link
Member Author

yankay commented Nov 11, 2024

"msg": "Failed to create object: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"admission webhook \"virtualmachine-validator.kubevirt.io\" denied the request: spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64.cloudInitNoCloud.userDataBase64 is not a valid base64 value.","reason":"Invalid","details":{"causes":[{"reason":"FieldValueInvalid","message":"spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64.cloudInitNoCloud.userDataBase64 is not a valid base64 value.","field":"spec.template.spec.volumes[1].cloudInitNoCloud.userDataBase64"}]},"code":422}\n'", "reason": "Unprocessable Entity

Failure (of the openeuler job) looks relevant Also, why put it in extended rather than regular runs ? Not stable enough ?

HI @VannTen

Thank you for your review. I have fixed the bug related to the base64 string in the code. Additionally, I have adjusted the CI configuration back to regular runs; previously, I had set it to extended runs to make the CI process faster.

@VannTen
Copy link
Contributor

VannTen commented Nov 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 81a66cc into kubernetes-sigs:master Nov 12, 2024
41 checks passed
@tico88612
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@tico88612 tico88612 mentioned this pull request Nov 27, 2024
Closed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@yankay @kpoxo6op
add ci for openeuler (kubernetes-sigs#11689)
a71c133 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 left review comments

@mzaian mzaian Awaiting requested review from mzaian

@woopstar woopstar Awaiting requested review from woopstar

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yankay @k8s-ci-robot @VannTen @tico88612