-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix calico-node template and remove flexvol-driver initContainer #11634
Fix calico-node template and remove flexvol-driver initContainer #11634
Conversation
Hi @KubeKyrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f7afc1d
to
53fe3f7
Compare
/ok-to-test |
53fe3f7
to
dcd2635
Compare
ef9df92
to
a8f9078
Compare
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
a8f9078
to
29ffe8a
Compare
@tico88612 @VannTen Could you help review it ? Thanks. |
I think this should be a bug fix for v3.28.1, not a new feature. (because we didn't follow upstream before this PR) /remove-kind feature
|
HI @cyclinder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have already discussed the changes in this PR with @KubeKyrie , and the code looks good.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@yankay Hi, kay, could you help give an approve to merge it? Thanks. |
Thanks @KubeKyrie |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyclinder, KubeKyrie, tico88612, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.26 |
@tico88612: new pull request created: #11676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
What type of PR is this?
/kind feature
What this PR does / why we need it:
update calico-nopde template and remove flexvol-driver initContainer, for calico has abandon it.
See https://github.com/projectcalico/calico/blob/v3.28.1/manifests/calico.yaml#L4757
The calico-node.yml template file has not been updated and it should follow calico version(currently v3.28.1).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
link projectcalico/calico#9338
Does this PR introduce a user-facing change?: