Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: remove in-tree cloud provider support #11633

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Cleanup: remove in-tree cloud provider support #11633

merged 7 commits into from
Nov 5, 2024

Conversation

tico88612
Copy link
Member

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Kubernetes v1.31 remove in-tree cloud provider related code, we should remove related support.

Which issue(s) this PR fixes:

Fixes #10495

Special notes for your reviewer:

Waiting for #11378 get merge.

Does this PR introduce a user-facing change?:

[action required] no longer support in-tree cloud provider, please delete or write `external` to the `cloud_provider` variable.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 15, 2024
@tico88612 tico88612 force-pushed the feat/remove-in-tree-cloud-provider branch 2 times, most recently from 5862062 to 041b9bd Compare October 15, 2024 06:52
@tico88612 tico88612 mentioned this pull request Oct 21, 2024
Merged
@tico88612 tico88612 mentioned this pull request Oct 29, 2024
Merged
@VannTen
Copy link
Contributor

VannTen commented Oct 31, 2024

I don't actually think we need to wait for #11378 : since kubernetes v1.31 does not support in-tree provider, even if kubespray has support, it won't work. So let's proceed with the removal 👍

VannTen
VannTen requested changes Oct 31, 2024
View reviewed changes
docs/advanced/gcp-lb.md Outdated Show resolved Hide resolved
docs/cloud_providers/aws.md Outdated Show resolved Hide resolved
roles/kubernetes/kubeadm/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes/node/defaults/main.yml Outdated Show resolved Hide resolved
roles/kubernetes/node/templates/kubelet.env.v1beta1.j2 Outdated Show resolved Hide resolved
roles/kubernetes/preinstall/tasks/0020-set_facts.yml Outdated Show resolved Hide resolved
roles/kubernetes/preinstall/tasks/0040-verify-settings.yml Outdated Show resolved Hide resolved
roles/kubespray-defaults/defaults/main/main.yml Outdated Show resolved Hide resolved
@tico88612 tico88612 force-pushed the feat/remove-in-tree-cloud-provider branch from 041b9bd to 3197fec Compare November 4, 2024 16:45
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2024
@tico88612
Docs: add removed message for cloud_provider
63ed2c7 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Docs: migrate to cloud_controllers
a2a1181 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Docs: edit cloud_provider description
0a2e68c 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Cleanup: remove all cloud_provider related tasks & files
437026f 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/remove-in-tree-cloud-provider branch from 3197fec to 207b4b5 Compare November 4, 2024 16:51
@tico88612 tico88612 marked this pull request as ready for review November 4, 2024 16:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@tico88612
Copy link
Member Author

/label tide/merge-method-merge
/ok-to-test

@k8s-ci-robot k8s-ci-robot added tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 4, 2024
@tico88612
Refactor: var kube_override_hostname only reserve in kubespray-defaults
c27cc33 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/remove-in-tree-cloud-provider branch from 207b4b5 to 13b1fb6 Compare November 4, 2024 17:02
@tico88612
Refactor: simpify cloud_provider is defined condition
38cd05c 
For this change, `cloud_provider` change the default value to empty
string.

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Refactor: simpify external_cloud_provider is defined
a070c72 
For this change, `external_cloud_provider` set default value to empty
string.

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/remove-in-tree-cloud-provider branch from 13b1fb6 to a070c72 Compare November 5, 2024 00:32
@tico88612 tico88612 requested a review from MrFreezeex November 5, 2024 01:17
MrFreezeex
MrFreezeex approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the massive cleanup 🙏
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@VannTen
Copy link
Contributor

VannTen commented Nov 5, 2024

/approve
Thanks for the work !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 107c3cc into kubernetes-sigs:master Nov 5, 2024
40 checks passed
bizhao added a commit to bizhao/kubespray that referenced this pull request Nov 21, 2024
@bizhao
Update README.md to fix several doc links for OpenStack and vSphere
eb5e1a2 
Fix 3 broken links.
Two of them are because of kubernetes-sigs#11633
@bizhao bizhao mentioned this pull request Nov 22, 2024
Merged
k8s-ci-robot pushed a commit that referenced this pull request Nov 25, 2024
@bizhao
Update README.md to fix several doc links for OpenStack and vSphere (#…
d4b2f8c 
…11736)

Fix 3 broken links.
Two of them are because of #11633
@tico88612 tico88612 mentioned this pull request Nov 27, 2024
Closed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@bizhao @kpoxo6op
Update README.md to fix several doc links for OpenStack and vSphere (k…
009f01e 
…ubernetes-sigs#11736)

Fix 3 broken links.
Two of them are because of kubernetes-sigs#11633
@spnngl spnngl mentioned this pull request Jan 10, 2025
Closed
@tico88612 tico88612 deleted the feat/remove-in-tree-cloud-provider branch January 12, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

@mzaian mzaian Awaiting requested review from mzaian

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloud provider deprecated in kubelet 1.27+
4 participants
@tico88612 @k8s-ci-robot @VannTen @MrFreezeex