Do not serialize fact gathering for no_proxy #11598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-action-required
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
VannTen
force-pushed
the
cleanup/fact_gathering
branch
2 times, most recently
from
d618590 to
cd29abc
Compare
The fallback_ips tasks are essentially serializing the gathering of one fact on all the hosts, which can have dramatic performance implications on large clusters (several minutes). This is essentially a reversal of 35f248d Being able to run without refreshing the cache facts is not worth it. We keep fallback_ip for now, simply changing the access to a normal hostvars variable instead of a custom dictionnary.
This should prevent confusing errors with undefined variables
VannTen
force-pushed
the
cleanup/fact_gathering
branch
from
cd29abc to
b0fb060
Compare
k8s-ci-robot
added
size/L
|
/retest-failed
|
1 similar comment
|
/retest-failed
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This essentially reverts #5957 , which means it gather ansible_default_ipv4 in parallel.
This means that using kubespray with --limits depends on the fact cache, but given that we have a dedicated playbook just for that and that it's the documented supported behavior, that makes it ok in my book.
Which issue(s) this PR fixes:
Fixes #11587
(I think it does, @sirkrypt0 could you test that patch to confirm ?)
Special notes for your reviewer:
This might need refinement but I'd like to test if the approach works.
Does this PR introduce a user-facing change?:
@rptaylor Thought this might interest you.
/label tide/merge-method-merge