Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support Fedora 39/40 #11573

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Feat: support Fedora 39/40 #11573

merged 4 commits into from
Oct 1, 2024

Conversation

tico88612
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related #11548

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support Fedora 39/40

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2024
@tico88612
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 25, 2024
@tico88612 tico88612 mentioned this pull request Sep 26, 2024
Closed
6 tasks
@tico88612
Copy link
Member Author

/retest-failed

@tico88612 tico88612 mentioned this pull request Sep 26, 2024
Merged
@tico88612
Copy link
Member Author

/retest

@tico88612 tico88612 changed the title Feat: support Fedora 39/40 [WIP] Feat: support Fedora 39/40 Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2024
@tico88612
Add Fedora 39/40 to Vagrantfile
78696c3 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/support-fedora-39-40 branch from e43762c to 6a47309 Compare September 29, 2024 08:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2024
@tico88612
Copy link
Member Author

Perfect, Fedora 39/40 passed all tests so that we can migrate about Fedora 37/38 CI tests.

image

@yankay @VannTen, please give this PR /approve if you think there is no problem.
After receiving the /approve, I will restore the CI to its original state (removing the last [WIP] commit).

VannTen
VannTen requested changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@VannTen VannTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small stuff.

Vagrantfile Show resolved Hide resolved
tests/files/packet_fedora39-calico-selinux.yml Outdated Show resolved Hide resolved
@tico88612 tico88612 force-pushed the feat/support-fedora-39-40 branch from 6a47309 to 750441e Compare September 30, 2024 00:14
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2024
@tico88612 tico88612 requested a review from VannTen September 30, 2024 00:32
@tico88612 tico88612 force-pushed the feat/support-fedora-39-40 branch from 750441e to 20a4485 Compare September 30, 2024 00:44
@tico88612
Add CI tests for Fedora 39/40
33dfc34 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Update CI tests documentation
336b934 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612
Update support OS version in README.md
3611b58 
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/support-fedora-39-40 branch from 20a4485 to 336ea7a Compare September 30, 2024 07:16
@tico88612 tico88612 requested a review from VannTen September 30, 2024 07:17
@VannTen
Copy link
Contributor

VannTen commented Sep 30, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@tico88612 tico88612 force-pushed the feat/support-fedora-39-40 branch from 336ea7a to 3611b58 Compare September 30, 2024 10:21
@tico88612 tico88612 changed the title [WIP] Feat: support Fedora 39/40 Feat: support Fedora 39/40 Sep 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@tico88612
Copy link
Member Author

/retest-failed

@tico88612
Copy link
Member Author

/retest

@tico88612
Copy link
Member Author

@yankay @VannTen, this PR is ready to merge. Could you give this PR /lgtm? Thanks!

@VannTen
Copy link
Contributor

VannTen commented Oct 1, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit b0563c2 into kubernetes-sigs:master Oct 1, 2024
40 checks passed
@tico88612 tico88612 deleted the feat/support-fedora-39-40 branch October 1, 2024 12:18
@tico88612 tico88612 mentioned this pull request Oct 6, 2024
Merged
@tico88612 tico88612 mentioned this pull request Nov 27, 2024
Closed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@tico88612 @kpoxo6op
Feat: support Fedora 39/40 (kubernetes-sigs#11573)
6a47c01 
* Add Fedora 39/40 to Vagrantfile

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>

* Add CI tests for Fedora 39/40

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>

* Update CI tests documentation

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>

* Update support OS version in README.md

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>

---------

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian Awaiting requested review from mzaian

@yankay yankay Awaiting requested review from yankay

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tico88612 @VannTen @k8s-ci-robot