Remove generation of static tokens for cluster members #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodes to api-server relies by default certificates, and bootstrap tokens, and there should be no need to generate tokens for every nodes, even when enabling static token auth.
k8s-ci-robot
added
release-note-action-required
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/approve cancel |
k8s-ci-robot
removed
the
approved
MrFreezeex
approved these changes
Sep 24, 2024
k8s-ci-robot
added
the
lgtm
mzaian
approved these changes
Sep 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@VannTen Is there anything we should do on existing clusters to clean up? |
|
I don't think so. As mentioned in the PR description, the token_auth was
disabled by default for a while. Lingering tokens should not be accepted
by a default configuration of kubespray, if I understand things correctly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This removes the generation of static tokens for the node in the Kubernetes cluster.
kube_token_authis disabled by default since d487b2f (in 2017).I also don't think that we actually using it for the nodes even when
kube_token_authis true.This DOES NOT remove
kube_token_auth.Special notes for your reviewer:
This does needs some discussion, so I'll remove implicit approval
/unapprove
Does this PR introduce a user-facing change?:
/label tide/merge-method-merge