-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to use exisitng fips with terraform openstack #11558
Add support to use exisitng fips with terraform openstack #11558
Conversation
Hi @anders-elastisys. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks @anders-elastisys |
/release-note-edit
|
@yankay @cyclinder Hi, I believe a reviewer needs to add a |
HI @tico88612 @VannTen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anders-elastisys, tico88612, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds Terraform Openstack support for specifying existing floating IPs on each machine listed in
k8s_nodes
andk8s_masters
with a new optional variablereserved_floating_ip
which is only used when thefloating_ip
variable is set to true. Ifreserved_floating_ip
is not set andfloating_ip
is true, a new floating IP will be created same as before.When
reserved_floating_ip
is set, that IP will get released and not deleted when deleting all Terraform resources.Known limitations:
reserved_floating_ip
on multiple hosts, Terraform will not complain and only one machine gets assigned the IP in the end, as there is currently no check for whether or not the specific IP has already been assigned. The output will show the same IP several times as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: