Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving yamllint configuration #11389

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

bbaassssiiee
Copy link
Contributor

@bbaassssiiee bbaassssiiee commented Jul 18, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

What this PR does / why we need it:
This updates the .yamllint configuration for better compatibility with ansible-lint.
It updates all the octal-values so that they are consistently quoted.
The yamlling in the CI and pre-commit will guard this style from now on.

Which issue(s) this PR fixes:

The blessed way to write octal values nowadays is:

- ansible.builtin.file:
    path: /etc/host
    state: file
    mode: "0644"
    owner: root
    group: root

The additions for .yamllint would surface 333 errors in master, these are fixed:

333 yaml[octal-values]           basic   formatting, yaml

Reference: https://ansible.readthedocs.io/projects/lint/rules/yaml/#octals

Fixes #

Special notes for your reviewer:
Derived from the conversation in #11384

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bbaassssiiee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from ant31 and bozzo July 18, 2024 13:41
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 18, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting up the PR!
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2024
@bbaassssiiee
Copy link
Contributor Author

Thanks for you patience in the review.

@MrFreezeex
Copy link
Member

Thanks for your patience as well and for improving kubespray :D ❤️

FYI your two PRs also need an approver review so you would have to bear with us a bit more 😅

@bbaassssiiee
Copy link
Contributor Author

🐄

@yankay
Copy link
Member

yankay commented Jul 24, 2024

Thanks @bbaassssiiee

A great change :-)
Could we squash the commits ,
and add the `question Does this PR introduce a user-facing change?: ' to the PR description ?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 24, 2024
@bbaassssiiee
Copy link
Contributor Author

bbaassssiiee commented Jul 24, 2024

Thanks! You could squash on merge, or did you imply that I rebase, sign, and signoff everything as one commit?

Signed-off-by: Bas Meijer <bas.meijer@enexis.nl>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@bbaassssiiee
Copy link
Contributor Author

I rebased, signed and signed-off.

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@yankay
Copy link
Member

yankay commented Jul 26, 2024

Thanks @bbaassssiiee
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbaassssiiee, MrFreezeex, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8f5f752 into kubernetes-sigs:master Jul 26, 2024
39 checks passed
@bbaassssiiee bbaassssiiee deleted the bugfix/yamllint branch July 30, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants