-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving yamllint configuration #11389
Improving yamllint configuration #11389
Conversation
Hi @bbaassssiiee. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting up the PR!
/lgtm
/ok-to-test
Thanks for you patience in the review. |
Thanks for your patience as well and for improving kubespray :D ❤️ FYI your two PRs also need an approver review so you would have to bear with us a bit more 😅 |
🐄 |
Thanks @bbaassssiiee A great change :-) |
Thanks! You could squash on merge, or did you imply that I rebase, sign, and signoff everything as one commit? |
Signed-off-by: Bas Meijer <bas.meijer@enexis.nl>
a593943
to
b72bf86
Compare
I rebased, signed and signed-off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @bbaassssiiee |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbaassssiiee, MrFreezeex, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This updates the .yamllint configuration for better compatibility with ansible-lint.
It updates all the octal-values so that they are consistently quoted.
The yamlling in the CI and pre-commit will guard this style from now on.
Which issue(s) this PR fixes:
The blessed way to write octal values nowadays is:
The additions for .yamllint would surface 333 errors in master, these are fixed:
Reference: https://ansible.readthedocs.io/projects/lint/rules/yaml/#octals
Fixes #
Special notes for your reviewer:
Derived from the conversation in #11384
Does this PR introduce a user-facing change?: