-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcloud: Added support for routers and gateways #11386
base: master
Are you sure you want to change the base?
Upcloud: Added support for routers and gateways #11386
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Xartos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Xartos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
I assume the failing tests aren't because of the changes in this PR? |
bce923c
to
b1dd817
Compare
b1dd817
to
e210ad7
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Could you rebase this PR to our upstream? |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I will wait for this PR to be merged, then I'll rebase it. So you only need to look at this commit
Does this PR introduce a user-facing change?: