-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external_openstack_cacert file from host #11377
base: master
Are you sure you want to change the base?
Conversation
Welcome @Nathanael-Mtd! |
Hi @Nathanael-Mtd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31, mzaian, Nathanael-Mtd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
134496f
to
5060928
Compare
Hi @yankay, I made a mistake the last time with a merge request instead of rebase (but fixed since weeks), and lgtm tag was removed. Can you re-check if it's ok, and @ErikJiang can you review this PR please ? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Same as with the in-tree openstack cloud controller, copy external_openstack_cacert file retrieved from ansible host to the control-plane for secret creation.
Does this PR introduce a user-facing change?: