Limit nodes in gather ansible_default_ipv4 #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Signed-off-by: tu1h <lihai.tu@daocloud.io>
|
@yankay @VannTen @ErikJiang PTAL:-) |
|
🤝 good job @tu1h /lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @tu1h |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tu1h, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When we specify
--limiton ansible-playbook cli which means we just want to restrict the operation to specified nodes. But for now, taskGather ansible_default_ipv4 from all hostswill attempt to get the addresses of all hosts, it's unnecessary and cause time consumption.So this solution is limiting the execution host in
groups['kube_control_plane'][0]and in--limit, if--limitexists.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: