-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic post upgrade hooks for node #11368
Add generic post upgrade hooks for node #11368
Conversation
Hi @j4m3s-s. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I think all the CI errors are unrelated since my change doesn't change the default behaviour. Please correct me if it isn't. |
/ok-to-test |
Thanks a lot @j4m3s-s The CI part is fine now. Could you please add a proper release note. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: j4m3s-s, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
We have a couple of software systems which need to have actions correlated during kubernetes upgrade. Having hooks to do that would help us
Which issue(s) this PR fixes:
Special notes for your reviewer:
I am unsure if it would be better to add a default in the inventory group_vars instead with an appropriate comment ?
Does this PR introduce a user-facing change?: