Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove Debian 10 support & macvlan test move to Debian 11 #11347

Merged

Conversation

tico88612
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Debian 10 (Buster) was EOL. We can remove this version of support.
  • Macvlan test move to Debian 12.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR cleans all Debian 10 related files. If I have missed any, please correct me in the review.

Does this PR introduce a user-facing change?:

Remove Debian 10 support.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from MrFreezeex and mzaian July 2, 2024 12:42
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2024
@tico88612
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 2, 2024
@tico88612 tico88612 force-pushed the remove/debian-10-support branch from 880c7a0 to 1bfcab1 Compare July 2, 2024 12:52
.gitlab-ci/packet.yml Outdated Show resolved Hide resolved
@tico88612 tico88612 force-pushed the remove/debian-10-support branch from 1bfcab1 to fb7fcb0 Compare July 2, 2024 14:06
@tico88612 tico88612 changed the title CI: Remove Debian 10 support & move macvlan test to Debian 12 CI: Remove Debian 10 support & macvlan test move to Debian 12 Jul 2, 2024
@tico88612
Copy link
Member Author

/retest-failed

@ant31
Copy link
Contributor

ant31 commented Jul 3, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@tico88612 tico88612 force-pushed the remove/debian-10-support branch from fb7fcb0 to e46b5ed Compare July 3, 2024 12:53
tico88612 added 3 commits July 3, 2024 21:23
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the remove/debian-10-support branch from e46b5ed to 0ca6e4f Compare July 3, 2024 13:23
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the remove/debian-10-support branch from 0ca6e4f to aeeec26 Compare July 3, 2024 13:26
@tico88612
Copy link
Member Author

Macvlan test will fail at Debian 12. I changed it to Debian 11.

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/7255832762

@ant31
Copy link
Contributor

ant31 commented Jul 3, 2024

/approve

Can you create an issue for macvlan ? Anyidea why it failes with 12 but not 11?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ant31
Copy link
Contributor

ant31 commented Jul 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 474b259 into kubernetes-sigs:master Jul 3, 2024
39 checks passed
@tico88612
Copy link
Member Author

Can you create an issue for macvlan ? Anyidea why it failes with 12 but not 11?

@ant31 Opened, #11349

@tico88612 tico88612 deleted the remove/debian-10-support branch July 3, 2024 16:18
@tico88612 tico88612 changed the title CI: Remove Debian 10 support & macvlan test move to Debian 12 CI: Remove Debian 10 support & macvlan test move to Debian 11 Jul 3, 2024
@tico88612
Copy link
Member Author

/cherrypick release-2.25

@k8s-infra-cherrypick-robot

@tico88612: new pull request created: #11429

In response to this:

/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay yankay mentioned this pull request Aug 28, 2024
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
…etes-sigs#11347)

* CI: macvlan test switch to debian 11 & default job

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

* CI: cilium-svc-proxy test switch to debian 12

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

* CI: remove debian 10 test

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

* Docs: remove debian 10 support

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

---------

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants