-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DigitalOcean external cloud provider and DO kubernetes controller #11327
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: simonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @simonoff! |
Hi @simonoff. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@@ -31,3 +32,7 @@ KUBELET_CLOUDPROVIDER="" | |||
{% endif %} | |||
|
|||
PATH={{ bin_dir }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin | |||
|
|||
{% if inventory_hostname in groups['kube_node'] and hostvars[inventory_hostname]['droplet_id'] is defined %} | |||
KUBELET_NODEID="--provider-id=digitalocean://{{ hostvars[inventory_hostname]['droplet_id'] }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create a variable kubelet_node_id and use it as a condition here.
can be configured via set_fact
in the external_cloud role
@@ -39,6 +39,9 @@ ExecStart={{ bin_dir }}/kubelet \ | |||
$DOCKER_SOCKET \ | |||
$KUBELET_NETWORK_PLUGIN \ | |||
$KUBELET_VOLUME_PLUGIN \ | |||
{% if external_do_cloud %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if kubelet_node_id
group: "{{ kube_cert_group }}" | ||
mode: 0640 | ||
with_items: | ||
- {name: external-do-csi-crds, file: external-do-csi-crds.yml} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are already installed by kubernetes-apps/csi_driver/csi_crd
I believe, which you could tweak the install condition in roles/kubernetes-apps/meta/main.yml
Please provide a more explicit release note, this provides no information. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Its possibility to deploy an unmanaged kubernetes clusters on DigitalOcean cloud provider.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE