Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigitalOcean external cloud provider and DO kubernetes controller #11327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DigitalOcean external cloud provider and DO kubernetes controller #11327

wants to merge 2 commits into from

Conversation

simonoff
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

Its possibility to deploy an unmanaged kubernetes clusters on DigitalOcean cloud provider.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Just a new external cloud provider support.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 26, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fedorchenko-a (8072b46)
  • ✅ login: simonoff / name: Oleksandr Simonov (62b7108)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonoff
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @simonoff!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @simonoff. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2024
@MrFreezeex
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2024
ant31
ant31 reviewed Jun 27, 2024
View reviewed changes
roles/kubernetes/node/templates/kubelet.env.v1beta1.j2
@@ -31,3 +32,7 @@ KUBELET_CLOUDPROVIDER=""
{% endif %}

PATH={{ bin_dir }}:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

{% if inventory_hostname in groups['kube_node'] and hostvars[inventory_hostname]['droplet_id'] is defined %}
KUBELET_NODEID="--provider-id=digitalocean://{{ hostvars[inventory_hostname]['droplet_id'] }}"
Copy link
Contributor

@ant31 ant31 Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a variable kubelet_node_id and use it as a condition here.

can be configured via set_fact in the external_cloud role

ant31
ant31 reviewed Jun 27, 2024
View reviewed changes
roles/kubernetes/node/templates/kubelet.service.j2
@@ -39,6 +39,9 @@ ExecStart={{ bin_dir }}/kubelet \
$DOCKER_SOCKET \
$KUBELET_NETWORK_PLUGIN \
$KUBELET_VOLUME_PLUGIN \
{% if external_do_cloud %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if kubelet_node_id

MrFreezeex
MrFreezeex reviewed Jun 29, 2024
View reviewed changes
roles/kubernetes-apps/external_cloud_controller/digitalocean/tasks/main.yml
group: "{{ kube_cert_group }}"
mode: 0640
with_items:
- {name: external-do-csi-crds, file: external-do-csi-crds.yml}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are already installed by kubernetes-apps/csi_driver/csi_crd I believe, which you could tweak the install condition in roles/kubernetes-apps/meta/main.yml

@VannTen
Copy link
Contributor

VannTen commented Aug 27, 2024

Please provide a more explicit release note, this provides no information.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant31 ant31 ant31 left review comments

@MrFreezeex MrFreezeex MrFreezeex left review comments

@VannTen VannTen Awaiting requested review from VannTen

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@simonoff @k8s-ci-robot @MrFreezeex @VannTen @ant31 @fedorchenko-a