-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerd: simplify registry mirror template #11326
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @clwluvw! |
Hi @clwluvw. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clwluvw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
973827b
to
e79aa60
Compare
Simplify registry mirror rendering in config.toml Signed-off-by: Seena Fallah <seenafallah@gmail.com>
e79aa60
to
4fb0cf1
Compare
/ok-to-test |
/retest |
/lgtm |
Thanks a lot @clwluvw Could you please write a proper release note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very simple and clean login
thanks
/lgtm |
Could you edit your commit message (or alternatively add a comment in the code) to explain why the end result is functionally identical ? Why I think I get the gist of it, it's not completely trivial so it's best to help future reader of the code understand why it is this way. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Simplify registry mirror rendering in config.toml
Does this PR introduce a user-facing change?: