Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI fail with download_localhost #11315

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix CI fail with download_localhost #11315

merged 1 commit into from
Jun 25, 2024

Conversation

yankay
Copy link
Member

@yankay yankay commented Jun 21, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Fix CI with fail docker pull in gitlab runner by change docker_host var

Which issue(s) this PR fixes:

Fixes #11313

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix CI with fail docker pull in gitlab runner by change DOCKER_HOST

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from cyclinder June 21, 2024 07:18
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mzaian June 21, 2024 07:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2024
@yankay yankay changed the title [WIP]fix-ci-packet_centos7-calico-ha-once-localhost [WIP] try fix-ci-packet_centos7-calico-ha-once-localhost Jun 21, 2024
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch 2 times, most recently from 27ee765 to 8338363 Compare June 21, 2024 09:39
@yankay yankay changed the title [WIP] try fix-ci-packet_centos7-calico-ha-once-localhost [WIP] Fix CI with fail docker pull in gitlab runner Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2024
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch from 8338363 to ac45bd4 Compare June 21, 2024 09:58
@yankay yankay changed the title [WIP] Fix CI with fail docker pull in gitlab runner Fix CI with fail docker pull in gitlab runner Jun 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
@yankay
Copy link
Member Author

yankay commented Jun 21, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 21, 2024
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch from ac45bd4 to e5641d9 Compare June 21, 2024 10:58
@yankay yankay changed the title Fix CI with fail docker pull in gitlab runner [WIP]Fix CI with fail docker pull in gitlab runner Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch 5 times, most recently from 55f4e9c to 0bdeb61 Compare June 24, 2024 03:06
@yankay yankay changed the title [WIP]Fix CI with fail docker pull in gitlab runner Fix CI with fail docker pull in gitlab runner Jun 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@yankay yankay changed the title Fix CI with fail docker pull in gitlab runner Fix CI fail with download_localhost Jun 24, 2024
tico88612
tico88612 reviewed Jun 24, 2024
View reviewed changes
.gitlab-ci/packet.yml Outdated
@@ -148,9 +148,10 @@ packet_centos7-calico-ha-once-localhost:
when: on_success
variables:
# This will instruct Docker not to start over TLS.
DOCKER_LOCALHOST_ENABLE: "true"
Copy link
Member

@tico88612 tico88612 Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have docker:26.1.4-dind in the service. (GitLab CI)
I'm wondering if we just need to add the DOCKER_HOST variable so that we don't need service docker start.

Suggested change
DOCKER_LOCALHOST_ENABLE: "true"
DOCKER_HOST: tcp://docker:2375

FYI: https://stackoverflow.com/questions/45316098/connecting-to-docker-in-docker-from-a-gitlab-ci-runner

(Or maybe I'm misunderstanding this fix.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tico88612 , it works.

@yankay yankay changed the title Fix CI fail with download_localhost [WIP]Fix CI fail with download_localhost Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch 3 times, most recently from 807bddb to 0166751 Compare June 25, 2024 01:53
@yankay
fix-ci-packet_centos7-calico-ha-once-localhost
e0ae3c7 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the fix-ci-packet_centos7-calico-ha-once-localhost branch from 0166751 to e0ae3c7 Compare June 25, 2024 01:54
@yankay yankay changed the title [WIP]Fix CI fail with download_localhost Fix CI fail with download_localhost Jun 25, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@tico88612
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit af0ac97 into kubernetes-sigs:master Jun 25, 2024
79 checks passed
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@yankay @Rickkwa
fix-ci-packet_centos7-calico-ha-once-localhost (kubernetes-sigs#11315)
6c50b61 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@tico88612 tico88612 mentioned this pull request Jul 7, 2024
Merged
@tico88612
Copy link
Member

/cherrypick release-2.25

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 15, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11382

In response to this:

/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay yankay mentioned this pull request Aug 28, 2024
Closed
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
@yankay @davidumea
fix-ci-packet_centos7-calico-ha-once-localhost (kubernetes-sigs#11315)
41b6454 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@yankay @kpoxo6op
fix-ci-packet_centos7-calico-ha-once-localhost (kubernetes-sigs#11315)
86bb9bc 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 left review comments

@cyclinder cyclinder Awaiting requested review from cyclinder

@mzaian mzaian Awaiting requested review from mzaian

Assignees

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: packet_centos7-calico-ha-once-localhost
4 participants
@yankay @k8s-ci-robot @tico88612 @k8s-infra-cherrypick-robot