Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.25] Allow empty kube_node group #11249

Merged
merged 1 commit into from
May 30, 2024
Merged

[release-2.25] Allow empty kube_node group #11249

merged 1 commit into from
May 30, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #11248

/assign VannTen

Allow to run kubespray with an empty kube_node group, to provision only the control plane

@VannTen
Allow empty kube_node group
9ca5ab1 
While uncommon, provisioning only a control plane is a valid use case,
so don't block it.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 30, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from cyclinder and yankay May 30, 2024 10:19
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2024
@VannTen
Copy link
Contributor

VannTen commented May 30, 2024

/lgtm
/assign @mzaian @yankay

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@VannTen
Copy link
Contributor

VannTen commented May 30, 2024 via email

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6443d43 into kubernetes-sigs:release-2.25 May 30, 2024
66 checks passed
@robertvolkmann
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2024
@robertvolkmann robertvolkmann mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

@yankay yankay Awaiting requested review from yankay

Assignees

@mzaian mzaian

@yankay yankay

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @VannTen @k8s-ci-robot @robertvolkmann @mzaian @yankay