Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical error when checking for boostrap-os #10867

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 1, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fix logical error when checking for the presence of the 'bootstrap-os' role in the play.
-> was introduced in #10590
Also remove some clutter along the way.

Which issue(s) this PR fixes:

Fixes #10825

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix logical error when checking for boostrap-os

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from EppO and yankay February 1, 2024 13:49
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2024
Also remove some clutter along the way.
@VannTen VannTen force-pushed the fix/no_proxy_collection branch from 078d2aa to ce91ed9 Compare February 1, 2024 14:11
@dibi-codes
Copy link
Contributor

I ran into this issue where bootstrap-os did not run with 1.24. This PR does fix the problem.

@VannTen
Copy link
Contributor Author

VannTen commented Feb 5, 2024

/cc @MrFreezeex

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Feb 5, 2024

/assign @mzaian
(for approval)

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen lgtm thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit f2bdd4b into kubernetes-sigs:master Feb 5, 2024
66 checks passed
VannTen added a commit to VannTen/kubespray that referenced this pull request Feb 25, 2024
k8s-ci-robot pushed a commit that referenced this pull request Feb 26, 2024
@MathiasRudolphSec
Copy link

There is a typo or a missing entry in the intersection check for the bootstrap-os role.
I have kubespray installed via ansible-galaxy and in my environment the role is called kubernetes_sigs.kubespray.bootstrap-os. The check is for kubernetes-sigs.kubespray.bootstrap-os (_ vs. -).

@mzaian mzaian mentioned this pull request Apr 26, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task failed Set no_proxy to all assigned cluster IPs and hostnames
7 participants