-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logical error when checking for boostrap-os #10867
Fix logical error when checking for boostrap-os #10867
Conversation
Also remove some clutter along the way.
078d2aa
to
ce91ed9
Compare
I ran into this issue where |
/cc @MrFreezeex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/assign @mzaian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VannTen lgtm thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also remove some clutter along the way.
There is a typo or a missing entry in the intersection check for the bootstrap-os role. |
Also remove some clutter along the way.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix logical error when checking for the presence of the 'bootstrap-os' role in the play.
-> was introduced in #10590
Also remove some clutter along the way.
Which issue(s) this PR fixes:
Fixes #10825
Special notes for your reviewer:
Does this PR introduce a user-facing change?: