Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.23] Fix hardcoded pod infra version #10806

Merged

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Jan 18, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The pod_infra_version should not be hardcoded and should instead dynamically change with the kube_major_version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix hardcoded pod infra version

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ErikJiang
Once this PR has been reviewed and has the lgtm label, please assign cristicalin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@ErikJiang ErikJiang force-pushed the update_pause_version_2.23 branch from ef73811 to f3cc72f Compare January 18, 2024 03:13
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@ErikJiang ErikJiang force-pushed the update_pause_version_2.23 branch from f3cc72f to 2d1cb34 Compare January 19, 2024 02:47
@floryut
Copy link
Member

floryut commented Jan 22, 2024

Force merging this one

@floryut floryut merged commit e09a7c0 into kubernetes-sigs:release-2.23 Jan 22, 2024
26 of 31 checks passed
@VannTen VannTen mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants