[containerd] add config support override_path

[yankay]

What type of PR is this?

/kind feature

What this PR does / why we need it:

override_path is the config of contained, ref : https://github.com/containerd/containerd/blob/main/docs/hosts.md#override_path-field

It's useful to configure registry mirrors , ref https://microk8s.io/docs/registry-private#configure-registry-mirrors-7

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[containerd] add config support `override_path`

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

HI @VannTen @floryut

Would you please help to review the PR :-)

[VannTen]

I'd drop the if.

Suggested change

	{% if mirror.override_path is defined %}
	override_path = {{ mirror.override_path | default('false') | string | lower }}
	{% endif %}
	override_path = {{ mirror.override_path | default('false') | string | lower }}

false is containerd default, so that's consistent.

(In fact I'd drop the if on skip_verify as well ^)

[yankay]

Thanks @VannTen

After thinking about the idea twice, there is a problem.

If "the if be dropped", every host.toml file will contain

skip_verify = false
override_path = false

although the skip_verify and override_path is not defined.
It's not necessary, and it makes the config file simpler.

So, I think the original PR is reasonable, and it keeps the same with skip_verify, making the code easier to read.

How about you think about that :-)

[VannTen]

After thinking about the idea twice, there is a problem. If "the `if` be dropped", every `host.toml` file will contain ``` skip_verify = false override_path = false ``` although the `skip_verify` and `override_path` is not defined.

Yeah, but those are false by default.

It's not necessary, and it makes the config file simpler.

Making the resulting config file simpler does not really buy anything, you could even argue that's having explicit settings is self-documenting. OTOH, making the **template** simpler help for future modifications and debugging.

[yankay]

After thinking about the idea twice, there is a problem. If "the if be dropped", every host.toml file will contain skip_verify = false override_path = false although the skip_verify and override_path is not defined.
Yeah, but those are false by default.
It's not necessary, and it makes the config file simpler.
Making the resulting config file simpler does not really buy anything, you could even argue that's having explicit settings is self-documenting. OTOH, making the template simpler help for future modifications and debugging.

Thanks for suggestion :-) 🤝🤝🤝

Got it. The code has been changed.

[VannTen]

Might want to rebase to get the vagrant fix 👍

[VannTen]

/lgtm