Fix etcd client generation #10769
Merged
Fix etcd client generation #10769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
VannTen
force-pushed
the
fix/etcd-certs-gen
branch
from
90b81d0 to
df2eb4a
Compare
k8s-ci-robot
added
size/S
VannTen
force-pushed
the
fix/etcd-certs-gen
branch
from
df2eb4a to
aca9b0d
Compare
k8s-ci-robot
added
size/M
This should allow to catch several class of problem rather than just one -> from network plugin such as calico or cilium talking directly to the etcd.
This has two benefits: - We don't play the etcd role twice for no reason - We have access to the whole cluster (if needed) to use things like group_by.
VannTen
force-pushed
the
fix/etcd-certs-gen
branch
from
aca9b0d to
1906de6
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/kind bug |
|
/cc @cyclinder |
|
Thanks a lot @VannTen |
k8s-ci-robot
added
the
approved
cyclinder
approved these changes
Jan 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyclinder, VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice fix! @VannTen /lgtm |
k8s-ci-robot
added
the
lgtm
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
* ci: redefine multinode to node-etcd-client This should allow to catch several class of problem rather than just one -> from network plugin such as calico or cilium talking directly to the etcd. * Dynamically define etcd host range This has two benefits: - We don't play the etcd role twice for no reason - We have access to the whole cluster (if needed) to use things like group_by.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Instead of running the etcd role twice (etcd:kube_control_plane / kube_node), with the second runs only necessary on setup requiring clients certs on
kube_nodehost, we dynamically define whetherkube_nodeneeds to be in the play.Benefits:
Which issue(s) this PR fixes:
Fixes #10757
Special notes for your reviewer:
Regarding the releases notes since this is a fix of a regression not released yet, maybe we should not include it in the releases notes ? (aka it's just noise)
Does this PR introduce a user-facing change?: