-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix etcdctl copy operation in crio #10242
fix etcdctl copy operation in crio #10242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🙏
/lgtm
AFAIK nerdctl can not run in crio.sock .
debug = false
debug_full = false
address = "{{ cri_socket }}" |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@yckaolalala You are right, |
@MrFreezeex @yankay PTAL, Thanks 😊 |
That's a nice trick :D |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, MrFreezeex, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently,
crictl
does not support the copy command, so I usecp /proc/${container_pid}/root/${file_path}
to fix the etcdctl copy operation for now.Which issue(s) this PR fixes:
Fixes #10240
Special notes for your reviewer:
Does this PR introduce a user-facing change?: