-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Calico to lowercase and fix broken calico link in README #10232
Conversation
Hi @Xieql. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xieql
/ok-to-test
Hi @Xieql, thanks for the contribution! Could you rebase your commit, the CI failure seems weird 🤔 |
Okay, I noticed the error, but I wasn't sure why it occurred or how to handle it. So, I performed ‘ git fetch --all ; git rebase upstream/master ’ and resubmitted the changes. but still failed ... |
I the CI failures are not related to the rebasing. all good now let's wait and see. |
Well actually I think that now that calico is lowercased the script to check if the versions in the readme are up to date is failing :( |
Okay, I tried not to modify it to test your idea. However, I still think it looks strange to have "calico" in uppercase when all the other words are in lowercase. |
still failed :( |
That was a random one, I've restarted and this is now fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, there is two other pipelines that are running so there may be some other "random CI failiures" but we should get there bear with us 🙏 :D.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, Xieql The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I see. In that case, I will change "calico" back to lowercase. XD |
No but the lowercase calico definitely doesn't work with the script |
Signed-off-by: Xieql <xieqianglong@huawei.com>
/lgtm |
Signed-off-by: Xieql <xieqianglong@huawei.com>
Signed-off-by: Xieql <xieqianglong@huawei.com>
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
1 update ”Calico“ to lowercase so that it can maintain consistency in capitalization with other Network Plugins names in parallel.
2 update calico link in README
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: