-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added terraform support for NIFCLOUD #10227
Added terraform support for NIFCLOUD #10227
Conversation
Welcome @ystkfujii! |
Hi @ystkfujii. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9d4e5b4
to
84ae392
Compare
@ystkfujii: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@ystkfujii: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
84ae392
to
d2adbbb
Compare
Hi @ystkfujii thanks for your contribution! Could you add a tf-validate job though? You can take a look at .gitlab-ci/terraform.yml to add it there. /ok-to-test |
c3a4597
to
fdf85a2
Compare
f824091
to
dede0dd
Compare
I updated about your comments. Could you please review again? |
dede0dd
to
e6aa034
Compare
Thanks for your contribution @ystkfujii /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, ystkfujii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
* Add NIFCLOUD * Add tf-validate-nifcloud in gitlab-ci
* Add NIFCLOUD * Add tf-validate-nifcloud in gitlab-ci
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR provides Terraform support for NIFCLOUD.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
To test, read the quickstart section in the README.
Does this PR introduce a user-facing change?: