-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[podSecurityConfiguration]: fix apiVersion and change default policy … #10210
[podSecurityConfiguration]: fix apiVersion and change default policy … #10210
Conversation
…versions Signed-off-by: Ugur <ugurozturk918@gmail.com>
Hi @ugur99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your contribution, looks good :).
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -1,5 +1,5 @@ | |||
{% if kube_pod_security_use_default %} | |||
apiVersion: pod-security.admission.config.k8s.io/v1beta1 | |||
apiVersion: pod-security.admission.config.k8s.io/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``pod-security.admission.config.k8s.io/v1 configuration requires v1.25+.
and the minimum version Kubespray supports is v1.25.0.
So it is fine to change here as this.
I did put a wrong label 😅 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, oomichi, ugur99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…versions (kubernetes-sigs#10210) Signed-off-by: Ugur <ugurozturk918@gmail.com>
…versions (kubernetes-sigs#10210) Signed-off-by: Ugur <ugurozturk918@gmail.com>
Signed-off-by: Ugur Can Ozturk ugurozturk918@gmail.com
What type of PR is this?
/kind api-change
What this PR does / why we need it:
According to the documentation, the api version of
pod-security.admission.config.k8s.io
was upgraded tov1
with versionv1.25
. Even thoughv1beta1
andv1alpha1
are not deprecated yet, I think we should use v1 one.And using the latest security standards can be confusing for people following the special version of Kubernetes documentation. It would be good if we change the security standard versions not to latest but same as major Kubernetes version to prevent this confusion. Even if it will be set as latest, it will be more appropriate for the user to do this consciously.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For testing purposes, a new cluster was set up and tested.
Does this PR introduce a user-facing change?: