-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused flannel_cni_download_url #10188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the commit 937e64d the variable has not been used at all. This removes it from offline.yml which was the remaining part.
k8s-ci-robot
added
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Jun 5, 2023
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jun 5, 2023
oomichi
changed the title
Remove flannel_cni_download_url
Remove unused flannel_cni_download_url
Jun 5, 2023
MrFreezeex
approved these changes
Jun 5, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @oomichi |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 5, 2023
palmeXx
pushed a commit
to palmeXx/kubespray
that referenced
this pull request
Jun 7, 2023
Since the commit 937e64d the variable has not been used at all. This removes it from offline.yml which was the remaining part.
maciej-markowski
pushed a commit
to maciej-markowski/kubespray
that referenced
this pull request
Jun 23, 2023
Since the commit 937e64d the variable has not been used at all. This removes it from offline.yml which was the remaining part.
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Since the commit 937e64d the variable has not been used at all. This removes it from offline.yml which was the remaining part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Since the commit 937e64d the variable has not been used at all.
This removes it from offline.yml which was the remaining part.
Which issue(s) this PR fixes:
Fixes #10171
Does this PR introduce a user-facing change?: