Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flannel_cni_download_url #10188

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Jun 5, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Since the commit 937e64d the variable has not been used at all.
This removes it from offline.yml which was the remaining part.

Which issue(s) this PR fixes:

Fixes #10171

Does this PR introduce a user-facing change?:

Remove unused flannel_cni_download_url

Since the commit 937e64d the variable
has not been used at all.
This removes it from offline.yml which was the remaining part.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from bozzo and jayonlau June 5, 2023 06:33
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2023
@oomichi oomichi changed the title Remove flannel_cni_download_url Remove unused flannel_cni_download_url Jun 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mzaian
Copy link
Contributor

mzaian commented Jun 5, 2023

Thanks @oomichi
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 08a571b into kubernetes-sigs:master Jun 5, 2023
palmeXx pushed a commit to palmeXx/kubespray that referenced this pull request Jun 7, 2023
Since the commit 937e64d the variable
has not been used at all.
This removes it from offline.yml which was the remaining part.
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
Since the commit 937e64d the variable
has not been used at all.
This removes it from offline.yml which was the remaining part.
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Since the commit 937e64d the variable
has not been used at all.
This removes it from offline.yml which was the remaining part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused variable
4 participants