-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the found version when it is incorrect #10109
Conversation
Hi @jcpunk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcpunk Thank you for the PR 👍
lgtm
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, jcpunk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your contribution! Looks good to me as well, could you rebase your PR to rekick the pipeline though (if no one relaunched it for you in the meantime)? |
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
Rebased off HEAD |
Thanks 🙏 |
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Includes the version of ansible in the failure message when it isn't compatible.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: