-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flannel image repo #10041
Update flannel image repo #10041
Conversation
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Thanks @ErikJiang |
@mzaian @jayonlau @MrFreezeex PTAL 😊 |
I think we are mirroring flannel to kubespray quai io so this is maybe why the path is still correct. /cc @floryut |
@@ -1001,7 +1001,7 @@ skopeo_binary_checksum: "{{ skopeo_binary_checksums[image_arch][skopeo_version] | |||
kube_proxy_image_repo: "{{ kube_image_repo }}/kube-proxy" | |||
etcd_image_repo: "{{ quay_image_repo }}/coreos/etcd" | |||
etcd_image_tag: "{{ etcd_version }}" | |||
flannel_image_repo: "{{ docker_image_repo }}/flannelcni/flannel" | |||
flannel_image_repo: "{{ docker_image_repo }}/flannel/flannel" | |||
flannel_image_tag: "{{ flannel_version }}" | |||
flannel_init_image_repo: "{{ docker_image_repo }}/flannelcni/flannel-cni-plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @ErikJiang
Should the flannel_init_image_repo change together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not be possible to change it because the v1.2.0
image is not found in flannel/flannel-cni-plugin.
@floryut PTAL 😊 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
I was trying to pull the flannel image repo, but it seems like it's no longer available. I did find out that the latest tag version of flannelcni/flannel is only v0.21.0, but apparently, it needs to be changed to flannel/flannel.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: