Removes Ansible reinstall in CI pipeline

[luksi1]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This removes the Ansible reinstall that is run on each job of the pipeline. These steps are already performed in the image. This should speed up the pipeline considerably.

Which issue(s) this PR fixes:

Fixes #10031

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

[CI] Removes Ansible reinstall from build pipeline

[k8s-ci-robot]

Hi @luksi1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[luksi1]

@MrFreezeex, I know you aren't assigned as a reviewer, but this work is in the same vain as the Dockerfile and pipleine work if you want to take a peak.

[MrFreezeex]

Sure, this make a lot of sense to me, thanks! :D
/ok-to-test
/lgtm

[MrFreezeex]

Actually it currently change something: when we test with the 2.11 requirements. We might just drop supporting the two requirements versions altogether and just keep one, both versions are end of life anyway right now so I don't believe it should change much...

[luksi1]

Actually it currently change something: when we test with the 2.11 requirements. We might just drop supporting the two requirements versions altogether and just keep one, both versions are end of life anyway right now so I don't believe it should change much...

Good catch @MrFreezeex! I missed the CI variable for ANSIBLE_MAJOR_VERSION and was under the presumption that we were simply re-installing Ansible, since the default values from the shell script were set to 2.12 as well as the requirements.txt.

I'm going to set this to draft because it certainly isn't ready-to-go as is, but I'd like to know how we should move forward with this, since speeding up, and slimming down, the test pipeline has value both from an administration maintenance point-of-view as well as giving developers faster feedback on their PRs. Either 1) we can agree that going forward, we'll only support one version of Ansible, get that work done, rebase this, and then simply merge this as-is or 2) we believe that using two versions is best for now and in that case, I'll alter this PR to include virtuell environments for each requirements.txt and then we should be ready-to-go with this. What are your thoughts?

It might even be nice to get some feedback as well from @floryut or @cristicalin, or some other maintainers, as this decision would change Kubespray's support matrix, moving from two Ansible versions down to one, if that's the consensus.

[luksi1]

@MrFreezeex, I just saw the changes in #10034 and it looks like that PR moves to a one Ansible version support model. If that is the case, let's rebase this after #10034 and we should be good to go.

[MrFreezeex]

Hi @luksi1, now that we have only one supported version of Ansible do you have some time to rebase your PR 🙏?

[MrFreezeex]

Could you remove the draft status as well 🙏?
/lgtm

[luksi1]

The draft status is now removed @MrFreezeex. I've also added ansible-base to the requirements.txt and ensured that it's a compatible version with ansible 7.6.0.

Good work on getting us moved over to a single Ansible version!

[MrFreezeex]

Hmmm the image doesn't build now, guessing it's because of ansible-base probably 🤔

[luksi1]

You are right @MrFreezeex and it appears that ansible-base is deprecated and ansible-core is a dependency on ansible, so ansible-base has been wrapped into ansible-core and ansible-core has become a dependency on ansible, so we only need to install ansible and then let ansible handle the dependency matrix. You can read about it here and here.

[MrFreezeex]

You are right @MrFreezeex and it appears that ansible-base is deprecated and ansible-core is a dependency on ansible, so ansible-base has been wrapped into ansible-core and ansible-core has become a dependency on ansible, so we only need to install ansible and then let ansible handle the dependency matrix. You can read about it here and here.

Indeed I also double checked and ansible 7.6.0 has a dependency with ansible-core like ansible-core~=2.14.6. So seems fair indeed 👍
/lgtm

[luksi1]

@MrFreezeex, do we need do anything more to get this merged?

[MrFreezeex]

no it should be fine, we just need an approval. Maybe @yankay or @floryut would you be able to give a look at this somewhat old PR? 🙏

[floryut]

no it should be fine, we just need an approval. Maybe @yankay or @floryut would you be able to give a look at this somewhat old PR? 🙏

Thank you for the PR indeed @luksi1

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, luksi1, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment