-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playbook names to support import via galaxy #10021
Conversation
Signed-off-by: Kasanic, Denis <denisx.kasanic@intel.com>
Hi @dkasanic. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🙏 :D
/lgtm
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkasanic Thank you, I've added a note as this can be a breaking change for any ci/iac.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkasanic, floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kasanic, Denis <denisx.kasanic@intel.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Pplaybooks with hyphens in the file name cannot be imported through galaxy collection. With these changes, users will be able to import remove_node.yml, recover_control.yml_plane.yml and upgrade_cluster.yml playbooks.
Which issue(s) this PR fixes:
Fixes #10019
Special notes for your reviewer:
Intentionally left the playbook file names unchanged in root directory to avoid changes needed for users that use kubespray directly or via submodule.
Does this PR introduce a user-facing change?: