Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heketi glusterfs daemonset readinessProbe initial delay seconds from variables #8307

Closed
zemkogabor opened this issue Dec 15, 2021 · 2 comments · Fixed by #8309
Closed

Heketi glusterfs daemonset readinessProbe initial delay seconds from variables #8307

zemkogabor opened this issue Dec 15, 2021 · 2 comments · Fixed by #8309
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@zemkogabor
Copy link
Contributor

zemkogabor commented Dec 15, 2021 •
edited
Loading

What would you like to be added:

Heketi glusterfs daemonset readiness and liveness probe timeout and initial delay seconds from variable.

Why is this needed:

In glusterfs daemonset readinessProbe initialDelaySeconds value is 3 (kupespray commit: aa9b8453). This is not enought for Cluster of Vagrant VMs. Please modify to bigger value, or add ansible variable for customise.

In #4612 commits reduced readinessProbe initialDelay from 60 to 3.
@zemkogabor zemkogabor added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 15, 2021
@floryut
Copy link
Member

floryut commented Dec 15, 2021 •
edited
Loading

Do you feel like up for opening a PR ?

zemkogabor added a commit to zemkogabor/kubespray that referenced this issue Dec 15, 2021
@zemkogabor
Glusterfs daemonset readiness and liveness params. kubernetes-sigs#8307
3ee73c3
@zemkogabor
Copy link
Contributor Author

PR created: #8309

@zemkogabor zemkogabor mentioned this issue Dec 15, 2021
Merged
k8s-ci-robot pushed a commit that referenced this issue Dec 23, 2021
@zemkogabor
Glusterfs daemonset readiness and liveness params. #8307 (#8309)
996ecca
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this issue Apr 16, 2022
@zemkogabor @sakuraiyuta
Glusterfs daemonset readiness and liveness params. kubernetes-sigs#8307…
11a77ac 
… (kubernetes-sigs#8309)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Jun 29, 2023
@zemkogabor @LuckySB
Glusterfs daemonset readiness and liveness params. kubernetes-sigs#8307…
44f67c9 
… (kubernetes-sigs#8309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Glusterfs daemonset readiness and liveness params. #8307 zemkogabor/kubespray
2 participants
@floryut @zemkogabor