Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flannel support for multi-arch deployments #6730

Closed
bshephar opened this issue Sep 22, 2020 · 4 comments
Closed

Add Flannel support for multi-arch deployments #6730

bshephar opened this issue Sep 22, 2020 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bshephar
Copy link

What would you like to be added:
Add support for a arm64 daemonset so that Flannel works on Raspberry Pis (Or other ARM64 devices) in multi-arch environments

Why is this needed:
If you're running some nodes on x86_64, and then add some ARM nodes, there is no daemonset created for Flannel to use the arm64 image. This means the new nodes are left in NotReady state until the daemonset is created for flannel pointing to the ARM64 image.

We just need to copy the existing template and create the manifest for it during the deployment.

╰─ k get nodes
NAME                           STATUS     ROLES          AGE   VERSION
k8s-master0.k8s.bne-home.net   Ready      master         8d    v1.19.1
k8s-master1.k8s.bne-home.net   Ready      master         8d    v1.19.1
k8s-master2.k8s.bne-home.net   Ready      master         8d    v1.19.1
k8s-node1.k8s.bne-home.net     Ready      ovirt,worker   8d    v1.19.1
k8s-node2.k8s.bne-home.net     Ready      ovirt,worker   8d    v1.19.1
k8s-node3.k8s.bne-home.net     NotReady   rpi,worker     30h   v1.19.1

Once a daemonset is created for it and the deployment re-run, the node comes online. The daemonset I have just used the same template you already had, but copied it and added the arm64 image instead. The result:

╰─ k get ds
NAME                 DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
kube-flannel         5         5         5       5            5           <none>                   9d
kube-flannel-arm64   1         1         1       1            1           <none>                   22h

We could probably use the same template though and just add some Jinja2 logic to it. But for now, I've just copied the template. I'll send you a pull request and we can discuss the best way to implement it if you would like to have this feature.

@bshephar bshephar added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2020
@floryut
Copy link
Member

floryut commented Sep 22, 2020

@bshephar Is this what you are looking for #6166 ?

@r3d3mpt10n
Copy link

Hey, yeah. That's what I was looking for. Not sure why I missed that one.

Cheers, lets go ahead and close this one off then. That one seems to cover all of it.

@floryut
Copy link
Member

floryut commented Sep 22, 2020

Neat, happy that it fit your needs :)

/close

@k8s-ci-robot
Copy link
Contributor

@floryut: Closing this issue.

In response to this:

Neat, happy that it fit your needs :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants