Support for custom kube node hostname during upgrades for AWS cloud provider

[mqasimsarfraz]

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature request

Currently there is a limitation to use internal hostnames in the inventory file while deploying kubernetes on AWS. I can understand that the limitation is coming from cloud provider [1][2] itself but it would be great if we can manage the mapping in kubespray. I am able to do fresh installs with custom hostname but since upgrades are doing kubectl node operations there is no way around it except updating the upgrade role to allow custom hostname. For example:

- name: See if node is in ready state
  shell: "{{ bin_dir }}/kubectl get nodes | grep {{ kube_node_name|default(inventory_hostname) }}"
  register: kubectl_nodes
  delegate_to: "{{ groups['kube-master'][0] }}"
  failed_when: false

I can add the tasks to get hostname using ec2_facts but we should leave that as a choice so no current workflow is impacted. Also, the default workflow with inventory_hostname will be retained till kube_node_name is defined.

Please let me know if owners agree to approve the feature request I will be happy to create the PR.

Environment:

• Cloud provider or hardware configuration:
  AWS

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.