Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations #4520

Merged
merged 1 commit into from
Jan 26, 2025
Merged

📖 doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations #4520

merged 1 commit into from
Jan 26, 2025

Conversation

camilamacedo86
Copy link
Member

doc: update the Artifacts with the latest changes on the EnvTest Makefile target configurations

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2025
@camilamacedo86 camilamacedo86 force-pushed the fix-doc-envtest-artefacts branch from b1d1cd7 to 07425ea Compare January 22, 2025 09:52
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2025
@camilamacedo86
Copy link
Member Author

/overwrite pull-kubebuilder-e2e-k8s-1-32-0

2 similar comments
@camilamacedo86
Copy link
Member Author

/overwrite pull-kubebuilder-e2e-k8s-1-32-0

@Kavinjsir
Copy link
Contributor

/overwrite pull-kubebuilder-e2e-k8s-1-32-0

Kavinjsir
Kavinjsir approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Kavinjsir,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2025
@camilamacedo86 camilamacedo86 force-pushed the fix-doc-envtest-artefacts branch from 07425ea to 02f8e8b Compare January 26, 2025 12:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 87b0139 into kubernetes-sigs:master Jan 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @Kavinjsir @k8s-ci-robot