Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values #4451

Merged
merged 1 commit into from
Jan 12, 2025
Merged

🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values #4451

merged 1 commit into from
Jan 12, 2025

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Dec 30, 2024 •
edited
Loading

This commit changes the code implementation so that the webhook values in the helm chart are not generated. Instead, only expose the values to enable or not webhooks

Closes: #4382

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2024
@camilamacedo86
Copy link
Member Author

/skip pull-kubebuilder-e2e-k8s-1-32-0

The k8s infra prow is not working yet with 1.32

@camilamacedo86
Copy link
Member Author

HI @monteiro-renato

Can you give a hand in this review?
Thx a lot

@camilamacedo86 camilamacedo86 force-pushed the fix-webhook-generation branch 3 times, most recently from 4bd0c1a to 1d664f8 Compare December 30, 2024 09:35
@camilamacedo86 camilamacedo86 mentioned this pull request Dec 30, 2024
Closed
@camilamacedo86
Copy link
Member Author

/override pull-kubebuilder-e2e-k8s-1-32-0

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-32-0

In response to this:

/override pull-kubebuilder-e2e-k8s-1-32-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 30, 2024
@camilamacedo86 camilamacedo86 changed the title 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values WIP: 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-webhook-generation branch 6 times, most recently from bbc1bd9 to 88b1d05 Compare December 30, 2024 11:38
@camilamacedo86 camilamacedo86 changed the title WIP: 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values Dec 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@camilamacedo86 camilamacedo86 changed the title 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values WIP 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-webhook-generation branch 3 times, most recently from d93f84d to 84f50b0 Compare December 30, 2024 13:15
@camilamacedo86 camilamacedo86 changed the title WIP 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values 🐛 (helm/v1alpha1) - fix webhooks generation by removing data from helm chart values Dec 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-webhook-generation branch 4 times, most recently from 932aadd to b291b42 Compare January 1, 2025 11:17
@monteiro-renato
Copy link
Contributor

HI @monteiro-renato

Can you give a hand in this review? Thx a lot

I will be quite busy until the 16th of January unfortunately 😞

@camilamacedo86 camilamacedo86 force-pushed the fix-webhook-generation branch from b291b42 to ed918ec Compare January 7, 2025 05:54
@camilamacedo86
(helm/v1alpha1) - fix webhook generation by removing data from helm c…
b570426 
…hart values

This commit changes the code implementation so that the webhook values in the helm chart are not generated. Instead, only expose the values to enable or not webhooks
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-32-0 b570426 link true /test pull-kubebuilder-e2e-k8s-1-32-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jan 12, 2025 •
edited
Loading

I’ll proceed with this approach to unblock the release.

The primary goal is to ensure that the data is not exported in the values. Because of this, any required changes are less critical, and we can release it as it is now.

Additionally, since the plugin is in alpha and represents an initial experimental version, I think this is acceptable. We hope the community will help us stabilize and improve it in future follow-ups.

@camilamacedo86 camilamacedo86 merged commit 55097d0 into kubernetes-sigs:master Jan 12, 2025
21 of 24 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-webhook-generation branch January 12, 2025 12:50
akagami-harsh pushed a commit to akagami-harsh/kubebuilder that referenced this pull request Jan 17, 2025
@camilamacedo86 @akagami-harsh
🐛 (helm/v1alpha1) - fix webhooks generation by removing data from hel…
756b4b5 
…m chart values (kubernetes-sigs#4451)

(helm/v1alpha1) - fix webhook generation by removing data from helm chart values

This commit changes the code implementation so that the webhook values in the helm chart are not generated. Instead, only expose the values to enable or not webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@mateusoliveira43 mateusoliveira43 Awaiting requested review from mateusoliveira43

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(helm/v1alpha): Not expose webhooks data
4 participants
@camilamacedo86 @k8s-ci-robot @monteiro-renato @mateusoliveira43