🐛 (go/v4): fix test e2e by ensuring that make manifests and generate are executed as part of the tests #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
camilamacedo86
changed the title
|
c/c @Adembc |
We are running make manifests and make generate in the github action when those should be called by the e2e tests since we can trigger those locally, for example, from IDE to troubleshooting
camilamacedo86
force-pushed
the
add-make-commands-to-e2e
branch
from
3b860ce to
107b809
Compare
|
I am moving forward because it is a nit/fix Also, anyone can propose further changes in follow ups |
camilamacedo86
added
the
lgtm
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 10, 2024
Apply the fix introduced in PR kubernetes-sigs#4122. The default markers in the code have been replaced with the values defined in the hack/docs, but this change was missed in the tutorial samples.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 11, 2024
Apply the fix introduced in PR kubernetes-sigs#4122. The default markers in the code have been replaced with the values defined in the hack/docs, but this change was missed in the tutorial samples.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 11, 2024
…ithout overwriting webhook markers Ensure we are more precise with operations to avoid overwriting the default scaffolding. Previously, the markers in the scaffold were unintentionally overwritten when injecting code and documentation, which could override crucial changes. This commit ensures the fix applied in PR kubernetes-sigs#4122 is preserved by refining the tutorial instructions to avoid overwriting webhook markers while still injecting the necessary information. Either we should not export the consts used in the hack/docs since those are internal implementations, therefore the consts used in this area affected have their name changed
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 11, 2024
…ithout overwriting webhook markers Ensure we are more precise with operations to avoid overwriting the default scaffolding. Previously, the markers in the scaffold were unintentionally overwritten when injecting code and documentation, which could override crucial changes. This commit ensures the fix applied in PR kubernetes-sigs#4122 is preserved by refining the tutorial instructions to avoid overwriting webhook markers while still injecting the necessary information. Either we should not export the consts used in the hack/docs since those are internal implementations, therefore the consts used in this area affected have their name changed
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 11, 2024
…ithout overwriting webhook markers Ensure we are more precise with operations to avoid overwriting the default scaffolding. Previously, the markers in the scaffold were unintentionally overwritten when injecting code and documentation, which could override crucial changes. This commit ensures the fix applied in PR kubernetes-sigs#4122 is preserved by refining the tutorial instructions to avoid overwriting webhook markers while still injecting the necessary information. Either we should not export the consts used in the hack/docs since those are internal implementations, therefore the consts used in this area affected have their name changed
camilamacedo86
added a commit
that referenced
this pull request
Sep 11, 2024
…of explanations (#4155) fix: improve CronJob and multiversion tutorial by refining replaces without overwriting webhook markers Ensure we are more precise with operations to avoid overwriting the default scaffolding. Previously, the markers in the scaffold were unintentionally overwritten when injecting code and documentation, which could override crucial changes. This commit ensures the fix applied in PR #4122 is preserved by refining the tutorial instructions to avoid overwriting webhook markers while still injecting the necessary information. Either we should not export the consts used in the hack/docs since those are internal implementations, therefore the consts used in this area affected have their name changed
|
I'm actually not super happy with this.
.PHONY: test-e2e
test-e2e: manifests generate fmt vetwhy not just add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running make manifests and make generate in the github action when those should be called by the e2e tests since we can trigger those locally, for example, from IDE to troubleshooting