✨ (go/v4) e2e tests: improve e2e tests and make test-e2e target #4106
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XXL
camilamacedo86
force-pushed
the
e2e-test-refine
branch
from
6c6ba0a to
61de3a4
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @kind get clusters | grep -q 'kind' || { \ | ||
| echo "No Kind cluster is running. Please start a Kind cluster before running the e2e tests."; \ | ||
| exit 1; \ | ||
| } |
There was a problem hiding this comment.
The changes on this PR should be enough to sort out the scenarios that you raised.
See that we need to have kind up and running for the e2e-tests
Therefore, if anyone run the integration tests without customize them against an env which is not using kind then the test will fail.
c/c @TAM360
There was a problem hiding this comment.
@camilamacedo86 I think the documentation should also include the information about newly introduced environment variables, and the purpose behind them.
There was a problem hiding this comment.
It is documented in the makefile target (see this file)
Also, in the e2e tests scaffolds golang docs.
So, I am not sure what/where more would like to see this info doc.
Please, note that by default the tests will now fails when someone runs in the scenarios where it is executed a cluster that is not kind. So, it will be very unlike someone be able to run make test-e2e against an env without be forced to know what test-e2e does and check its scaffold
There was a problem hiding this comment.
@camilamacedo86 wouldn't it be better idea to include it in the docs as well?
There was a problem hiding this comment.
@camilamacedo86 wouldn't it be better idea to include it in the docs as well?
It is not the goal of this PR
but we can add that under reference in a follow up.
I am totally OK with. Could you please raise an issue to track the need?
There was a problem hiding this comment.
@camilamacedo86 I'll create a new issue, once this PR merges.
camilamacedo86
force-pushed
the
e2e-test-refine
branch
2 times, most recently
from
6d6e66e to
ed4e17c
Compare
camilamacedo86
changed the title
|
@Adembc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
- Ensure that kind is installed and running before run the tests. Otherwise it will fail since we need to load the Manager(Operator) image - Add logic to skip the installation of CertManager and/or Prometheus via envvars. - Ensure that the promethues and certmanager are installed in the suite test instead of beafore each test - Ensure that the image is build and load in the suite instead instead for each test - Add more comments to clarify the purpose of the tests - Add TODO(user) to clarify that is expected action for the users to suplement and/or customize their e2e tests according to their needs
camilamacedo86
force-pushed
the
e2e-test-refine
branch
from
ed4e17c to
e3ea024
Compare
|
Moving forward since we have the LGTM from who asked for it and it was discussed in the slack We either can push new changes and further improvements in follow ups. |
camilamacedo86
added
the
lgtm
camilamacedo86
merged commit fa8b88f
into
kubernetes-sigs:master
Closes: #4089
c/c @DerekTBrown, @majewsky @TAM360 @defo89