Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix typo in designs template #4056

Merged
merged 1 commit into from
Aug 5, 2024
Merged

📖 Fix typo in designs template #4056

merged 1 commit into from
Aug 5, 2024

Conversation

gabriele-wolfox
Copy link
Contributor

This patch fixes a typo inside designs template.
"Implementeble" should be replaced by "Implementable".

Signed-off-by: gabriele-wolfox gabriele.wolfox@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @gabriele-wolfox. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
@gabriele-wolfox
Copy link
Contributor Author

@mateusoliveira43 moving the PR here in this branch.
Thanks for the help, it is my first PR here.

@mateusoliveira43
Copy link
Contributor

@gabriele-wolfox no problem 😄

You can check Contributing docs for more info https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md

I think there is an extra commit changing a dependency version, that should be removed

@gabriele-wolfox
Copy link
Contributor Author

I think there is an extra commit changing a dependency version, that should be removed

Yes, I am going to remove it tomorrow

camilamacedo86
camilamacedo86 reviewed Aug 5, 2024
View reviewed changes
docs/book/src/component-config-tutorial/testdata/project/go.mod Outdated
@@ -5,7 +5,7 @@ go 1.20
require (
k8s.io/apimachinery v0.28.1
k8s.io/client-go v0.28.1
sigs.k8s.io/controller-runtime v0.16.1
sigs.k8s.io/controller-runtime v0.16.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to revert the changes in the code if the goal is just the doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the goal is just the doc.
Removed, and thanks.

@gabriele-wolfox gabriele-wolfox force-pushed the fix-typo branch 3 times, most recently from 1abf21d to 4e1bef7 Compare August 5, 2024 18:17
@gabriele-wolfox
fix: typo in designs template
b90e047 
Signed-off-by: Gabriele Quaresima <gabriele.quaresima@enterprisedb.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
camilamacedo86
camilamacedo86 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, gabriele-wolfox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit b5235ef into kubernetes-sigs:master Aug 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabriele-wolfox @k8s-ci-robot @mateusoliveira43 @camilamacedo86