-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (Only relevant for users of Kubebuilder as a library) - Add new cli option and allow access to underlying cli command #4011
Conversation
Hi @beatrausch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c.fs = fs | ||
return nil | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with we create this one.
Just one thing, see that you can pass the FS such as
&CLI{
fs: machinery.Filesystem{FS: afero.NewMemMapFs()},
}
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but only internally.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see why not add both.
Thank you for your contribution 🥇
/approved
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beatrausch, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces a new CLI option WithFilesystem to set the filesystem when using kubebuilder as library. Furthermore, it allows access to the underlying cobra command.
Motivations
Both features are introduced to improve testability when using kubebilder as lib. Accessing the underlying command allows to pass call arguments to in tests.
For more information see #4006