Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (Only relevant for users of Kubebuilder as a library) - Add new cli option and allow access to underlying cli command #4011

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

beatrausch
Copy link
Contributor

This PR introduces a new CLI option WithFilesystem to set the filesystem when using kubebuilder as library. Furthermore, it allows access to the underlying cobra command.

Motivations
Both features are introduced to improve testability when using kubebilder as lib. Accessing the underlying command allows to pass call arguments to in tests.

For more information see #4006

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @beatrausch. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

c.fs = fs
return nil
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with we create this one.
Just one thing, see that you can pass the FS such as

&CLI{
   fs: machinery.Filesystem{FS: afero.NewMemMapFs()},
}

as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but only internally.

@camilamacedo86 camilamacedo86 changed the title ✨ Add new cli option and allow access to underlying cli command ✨ (Relevant only for who consume Kubebuilder as Lib) - Add new cli option and allow access to underlying cli command Jul 11, 2024
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2024
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see why not add both.
Thank you for your contribution 🥇

/approved
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beatrausch, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ (Relevant only for who consume Kubebuilder as Lib) - Add new cli option and allow access to underlying cli command ✨ (Only relevant for users of Kubebuilder as a library) - Add new cli option and allow access to underlying cli command Jul 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit a3a622e into kubernetes-sigs:master Jul 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants