Documentation for Finalizers does not return error

[weters]

In the using_finalizers.md page of the kubebuilder book, the example returns a nil error when an error occurs.

I think it should be the following instead since they both should requeue the request, but actually returning an error when an error occurs seems like it's the more correct solution.

                        if err := r.Update(context.Background(), instance); err != nil {
-                               return reconcile.Result{Requeue: true}, nil
+                               return reconcile.Result{}, err
                        }

[droot]

The PR is merged, so closing this.

[justinsb]

/close

(I presume)

[k8s-ci-robot]

@justinsb: Closing this issue.

In response to this:

/close

(I presume)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.