-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention KREW_ROOT
on instruction
#774
Mention KREW_ROOT
on instruction
#774
Conversation
|
Welcome @JohnTitor! |
/assign @ahmetb |
this is not worth changing just because of |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, JohnTitor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related issue: #767
The instruction on
krew/hack/krew.yaml
Lines 13 to 16 in 93827db
KREW_ROOT
but one on cmd/krew/cmd/internal/setup_check.go doesn't.This tweaks that instruction to mention
KREW_ROOT
there too.The fish command is a bit long as there's no simple alternative to the unset variables on fish AFAIK.